cvs commit: src/sys/dev/ata ata-all.h

[Nate Lawson]

Poul-Henning Kamp wrote:
> phk         2008-01-02 20:31:14 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/ata          ata-all.h 
>   Log:
>   Follow the current fashion of gratuitously stomping into other
>   peoples code with irrelevant changes[1]:
>   
>   Use bus_{read|write_*() instead of bus_space_{read|write}_*() for
>   purely stylistic reasons.
>   
>   Due to compiler optimizations and inlining, this is for all practical
>   purposes without effect in the compiled code.

Ok, but this still doesn't address the performance loss fixed by this
3-year-old patch:

http://lists.freebsd.org/pipermail/freebsd-current/2005-January/044858.html

>   Revision  Changes    Path
>   1.127     +14 -36    src/sys/dev/ata/ata-all.h
> 
> 
> Index: src/sys/dev/ata/ata-all.h
> diff -u src/sys/dev/ata/ata-all.h:1.126 src/sys/dev/ata/ata-all.h:1.127
> --- src/sys/dev/ata/ata-all.h:1.126	Thu Dec 13 11:47:36 2007
> +++ src/sys/dev/ata/ata-all.h	Wed Jan  2 20:31:14 2008
> @@ -579,56 +579,34 @@
>  
>  /* macros to hide busspace uglyness */
>  #define ATA_INB(res, offset) \
> -	bus_space_read_1(rman_get_bustag((res)), \
> -			 rman_get_bushandle((res)), (offset))
> +	bus_read_1((res), (offset))

-- 
Nate