cvs commit: src/sys/kern vfs_mount.c

Dag-Erling Smørgrav des at
Mon Feb 18 11:30:43 PST 2008

Yar Tikhiy <yar at> writes:
> Dag-Erling Smørgrav <des at> writes:
> > Can you guarantee that this will not f*** up the bootp / dhcp +
> > nfsroot case?  There are dragons in that code which were decidedly
> > not funny to track down and fix.
> Indeed; or, as a Russian proverb has it, "Just don't touch the sh*t,
> and it won't stink". :-) But, fortunately, I've just had a chance to
> test this WRT the NFS_ROOT case.  Thank Daemon, that code path is much
> clearer now than it used to be in the 4.4BSD days.

In other words, "no", or possibly "I don't want to answer your

There are at least two quite different code paths that may lead to
having an NFS-mounted root file system.  Since you won't give me a
proper answer, I have to assume that you only tested the easy one,
i.e. pxeboot with a GENERIC kernel; and in that case, as the person who
unf***ed both of the NFSROOT code paths the last time around, I support
Craig's request to have this backed out and properly reviewed.

Dag-Erling Smørgrav - des at

More information about the cvs-src mailing list