cvs commit: src/sbin/mount_nfs mount_nfs.c

Craig Rodrigues rodrigc at
Mon Feb 18 09:40:06 PST 2008

On Mon, Feb 18, 2008 at 05:20:14PM +0300, Yar Tikhiy wrote:
> This horrible hack is necessary because Someone(tm) started converting
> our NFS client to the new nmount(2) semantics a year ago but he has
> never finished the job.  Now the NFS client just uses old mount(2)

Yes, I acknowledge I started this work and did not finish.
I have some pending patches to fully convert mount_nfs to
pass nmount() string args to the kernel, but I am in the middle
of moving, so do not have time to do a lot of FreeBSD work until the end of
next week, when I move into my new house.

Additionally, touching the NFS mount code is quite involved, 
so once I am ready to get back to FreeBSD work, I want to circulate
the patches a bit more for feedback and testing before committing.

>> change and 1.274 to vfs_mount.c out, until we can analyze
>> the full implications of your change, and properly fix the
>> necessary infrastructure, instead of committing hack after hack?
> Which else _hacks_ did I commit?

The mount_nfs hack is the main one that I saw.  Can you revert
that plus the vfs_mount.c change until we have time to do this right?

Some other people already mentioned possible implications
of your change to NFS + bootp, which you didn't test.


Craig Rodrigues
rodrigc at

More information about the cvs-src mailing list