cvs commit: src/lib/libc/locale utf8.c

Andrey Chernov ache at nagual.pp.ru
Fri Oct 26 17:46:08 PDT 2007


On Fri, Oct 26, 2007 at 04:26:41PM -0700, John-Mark Gurney wrote:
> > Although standard permits functions only, I object against permanent 
> > removing inlines from ctype. Almost every system have them as macros or 
> > inlines and not as function calls, and it is for reason. Ctype functions 
> > are very inside-loop-intensive, and not speeding them up may slowdown apps 
> > which do intensive text processing.
> 
> Have you done benchmarks to prove that making it a function will slow
> it down significantly?  Things have changed over the years....

They slowed as function call with parameter can slow, the rest depends on 
application. The same is true about, say getc() macro vs. function 
call, especially noting that they usually are called in pair in the same 
loop. If we don't need inlines/macros here, why to keep getc() as macro?
getc() is much more slower by the nature because requires physical IO, so 
it will be very strange to keep getc() as macro but remove ctype.

-- 
http://ache.pp.ru/


More information about the cvs-src mailing list