cvs commit: src/lib/libstand tftp.c

Marius Strobl marius at FreeBSD.org
Sun Oct 21 10:03:18 PDT 2007


marius      2007-10-21 17:03:18 UTC

  FreeBSD src repository

  Modified files:
    lib/libstand         tftp.c 
  Log:
  - Given that we tell the compiler that struct ip is packed and 32-bit
    aligned, GCC 4.2.1 also generates code for sendudp() that assumes
    this alignment. GCC 4.2.1 however doesn't 32-bit align wbuf, causing
    the loader to crash due to an unaligned access of wbuf in sendudp()
    when netbooting sparc64. Solve this by specifying wbuf as packed and
    32-bit aligned, too. As for lastdata and readudp() this currently is
    no issue when compiled with GCC 4.2.1, though give lastdata the same
    treatment as wbuf for consistency and possibility of being affected
    in the future. [1]
  - Sprinkle const on a lookup table.
  
  Reported by:            marcel [1]
  Submitted by:           yongari [1]
  Reviewed by:            marcel [1]
  MFC after:              5 days
  
  Revision  Changes    Path
  1.13      +4 -4      src/lib/libstand/tftp.c


More information about the cvs-src mailing list