cvs commit: src/etc/defaults rc.conf src/etc/rc.d ppp
Bjoern A. Zeeb
bzeeb-lists at lists.zabbadoz.net
Fri Oct 12 14:55:06 PDT 2007
On Fri, 12 Oct 2007, Maksim Yevmenkin wrote:
> On 10/12/07, Bjoern A. Zeeb <bzeeb-lists at lists.zabbadoz.net> wrote:
>> On Fri, 12 Oct 2007, Maksim Yevmenkin wrote:
>>> emax 2007-10-12 16:35:36 UTC
>>> FreeBSD src repository
>>> Modified files:
>>> etc/defaults rc.conf
>>> etc/rc.d ppp
>>> Teach /etc/rc.d/ppp to start multiple instances of ppp.
>>> ppp_profile variable can now contain multiple profiles.
>>> Overrides for ppp mode and nat can go into ppp_$profile_mode
>>> and ppp_$profile_nat variables respectively. If those are
>>> not specified, defaults from ppp_mode and ppp_nat are used.
>>> Submitted by: Yuri Kurenkov < y dot kurenkov at init dot ru >
>>> Reviewed by: mtm
>>> MFC after: 1 week
>>> Revision Changes Path
>>> 1.319 +6 -0 src/etc/defaults/rc.conf
>>> 1.14 +43 -9 src/etc/rc.d/ppp
>> which should also provide a fallback to the global
>> setting in case the _profile on is not given...
> the version i have committed provides fallback to default ppp_mode and
> ppp_nat if profile specific mode and nat overrides were omitted.
Ah. Yes. Looked at the new version, not just half of the change;)
Seems yours is a lot better worked out and looks way cleaner:-)
a) do we really need that su -c ""? I have no idea what ppp_user had
done so far (did anything)?
b) could you grab that last change, that rc.d/jail has as well, so it
would be possible to start/stop/.. a single instance by giving the
profile name after the start/stop/...?
Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT
Software is harder than hardware so better get it right the first time.
More information about the cvs-src