cvs commit: src/contrib/binutils/opcodes ppc-dis.c

[David O'Brien]

On Sat, Nov 24, 2007 at 12:10:08AM +0000, John Birrell wrote:
> On Sat, Nov 24, 2007 at 01:03:30AM +0100, Kris Kennaway wrote:
> > John Birrell wrote:
> > >jb          2007-11-23 23:54:45 UTC
> > >
> > >  FreeBSD src repository
> > >
> > >  Modified files:
> > >    contrib/binutils/opcodes ppc-dis.c 
> > >  Log:
> > >  Fix strict alias warnings.
> > >  
> > >  Revision  Changes    Path
> > >  1.2       +119 -37   src/contrib/binutils/opcodes/ppc-dis.c
> > 
> > Usually we try to avoid taking files off the vendor branch, it causes 
> > trouble for the person doing the vendor imports :(
> 
> I know that. I nearly mentioned it in the commit message.
> 
> I think it's a change that doesn't need to be merged. If a new version
> is imported, _that_ needs to be build clean.

PLEASE discuss changes like this before committing them.
For one, we typically don't go around fixing warnings in contributed
code.  Second a courtesy email to me (or IRC poke) would have been nice -
as I've been talking with the embedded folks about their needs for a
binutils upgrade
- you've just added more effort to the task - *forever*.

-- 
-- David  (obrien at FreeBSD.org)