cvs commit: src/lib/libkse Makefile src/lib/libthr Makefile
src/usr.bin/netstat Makefile src/usr.sbin/acpi/acpidb
Makefile src/usr.sbin/kldxref Makefile src/usr.sbin/nscd
Makefile src/usr.sbin/rpc.yppasswdd Makefile
des at des.no
Tue Nov 20 05:24:56 PST 2007
John Birrell <jb at what-creek.com> writes:
> The thing that I take issue with is holding off re-enabling the WARNS
> -Werror checks which used to serve us well simply because there are
> custom CFLAGS set on the tinderboxes which cause non-fatal errors
> that nobody _ever_ _looks_ _at_. The errors are non-fatal because
> -Werror was disabled.
The errors are serious and should be fixed. They represent *actual
bugs* or at the very least serious design issues in the code. Nobody
benefits from sweeping them under the rug.
The reason why nobody looks at them is *precisely* the fact that they
don't stop the build. This is *precisely* why I disapprove of the use
> As an exercise to the readers of this message, please take a look
> at src/lib/libthr, our preferred threading library.
libthr has serious aliasing issues which I have commented on before. I
will not discuss them further on a public list.
> I would prefer that the tinderboxes run with the same defaults that
> we have in CVS, however, from what I have seen today, I think that we
> may need to rethink our defaults.
I have said this repeatedly in the past. Perhaps someone will listen
when it isn't me saying it?
Dag-Erling Smørgrav - des at des.no
More information about the cvs-src