cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

Poul-Henning Kamp phk at
Fri Nov 16 15:36:59 PST 2007

In message <473E25F5.1090805 at>, Scott Long writes:

>Ok, back on track.  What you want to do is make g_access largely 
>irrelevant, and have the _real_ access check done in g_start.  Fine.

Only for drive mechanisms that require out of band ioctls issued
over the inband channel in order to enable access to the media.

In other words CD drives.

>Is there any reason at all to make g_access not return success from
>now on? 

g_access is also responsible for checking read/writeability of the
media against the requested permissions.

>is what I'm arguing against; you're advocating a hack that works well
>enough for you and ignoring the larger architectural issue, which I
>think is important.  But anyways.

I think you misunderstand something here.

The only suggested change is that the printfs in geom gets supressed
for this one particular errno.

Nothing else changes as far as I know.

Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.

More information about the cvs-src mailing list