cvs commit: src/sys/kern kern_kse.c

[Julian Elischer]

Steve Kargl wrote:
> On Thu, Nov 15, 2007 at 09:48:13AM -0800, Julian Elischer wrote:
>> Gleb Smirnoff wrote:
>>> glebius     2007-11-15 14:16:20 UTC
>>>
>>>  FreeBSD src repository
>>>
>>>  Modified files:
>>>    sys/kern             kern_kse.c 
>>>  Log:
>>>  Fix build.
>> thanks.. I need to remember to stop applying patches 
>> from build tree to checkin tree by hand.
>>
>> the trouble is I can't commit from my current test machine (no 
>> internet access) so after testing, I make a patch and move to 
>> to my commit machine, where I can commit it, but
>> when it's a small patch, one is always tempted to 
>> do it by hand and then ...
>>
>> Julian, repeat after me..
>>
>> "no matter how small the change, use diff + patch to move it across."
> 
> After applying the patch on your commit machine, is it too
> difficult to actually retest before committing?  This would
> catch the broken commit before it becomes a Tinderbox issue.
> 
> Seems to be a QA problem on your part.

yes.. but I can't do a compile from my mac. (my commit machine).
The answer is to be rigorous about how I move the patch from the build
machine to the commit machine.

This is a temporary situation. new infrastructure will let me commit 
from my build machine again.




>