cvs commit: src/usr.sbin/sysinstall config.c dmenu.c

Ken Smith kensmith at
Thu Nov 1 06:07:28 PDT 2007

kensmith    2007-11-01 13:07:28 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_7)
    usr.sbin/sysinstall  config.c dmenu.c 
  MFC v1.243 of config.c and v1.48 of dmenu.c - fixes needed because
  sysinstall had made bad assumptions about the behavior of getenv(3)
  and the new getenv(3) doesn't behave the same as the old one did
  if you call it with getenv("amd_enable=YES").
  It was noted during review that the use of strdup(3) here is wrong
  and should be checked for NULL.  It's worth noting that's what I meant
  when I said I conformed to sysinstall's style despite urges to do otherwise
  in the original commit.  sysinstall is in desperate need of some major
  rototilling (or being thrown out...).
  Approved by:    re (rwatson)
  Revision   Changes    Path  +6 -1      src/usr.sbin/sysinstall/config.c   +8 -4      src/usr.sbin/sysinstall/dmenu.c

More information about the cvs-src mailing list