cvs commit: src Makefile.inc1

[Alexander Leidinger]

Quoting Dag-Erling Smørgrav <des at des.no> (from Tue, 15 May 2007  
08:12:41 +0200):

> Alexander Leidinger <Alexander at Leidinger.net> writes:
>> Dag-Erling Smorgrav <des at FreeBSD.org> writes:
>> > Alexander Leidinger <Alexander at Leidinger.net> writes:
>> > > Why did you remove the echo?
>> > which echo?  about schg?  it was completely bogus.
>> Yes. I don't think so, please explain.
>
> It would show up incorrectly if you declined to remove a file.
>
>> > feel free to re-add it, but only if you also add logic to check whether
>> > the file actually has the schg flag set before running chflags.
>> In the current code it doesn't make sense, and the wording can be
>> changed to tell that it will remove schg, in case this flag is set. As
>> you did the change and I don't have time to commit such a change when
>> I'm back at home (the place where I can make commits), would you
>> please add the echo again?
>
> That would mean an extra line of output for every single file...

What about another idea: removing the chflags all together and let the  
removal fail (with a message that the file may be protected with schg  
and it should be removed with chglags). This way only a message  
appears when the rm fails (saying no to the removal question of rm is  
not a failure/exit!=0).

>> > >  - bug(?): ${DESTDIR} in the rm line
>> > no, this is intentional, and in fact the original code had it too.
>> The original code hat it before, but you CD into DESTDIR, so it is not
>> necessary anymore.
>
> Unless someone goofs and adds an absolute path to ObsoleteFiles.inc...
> which is why I very deliberately left "${DESTDIR}/" in front of the path
> in the rm command, although I could probably replace it with "./".

That would make it more consistent.

Bye,
Alexander.

-- 
War doesn't prove who's right, just who's left.

http://www.Leidinger.net    Alexander @ Leidinger.net: PGP ID = B0063FE7
http://www.FreeBSD.org       netchild @ FreeBSD.org  : PGP ID = 72077137