cvs commit: src/sys/dev/usb ukbd.c

[Erwin Lansing]

On Sat, Jun 16, 2007 at 10:01:17PM +0200, Wilko Bulte wrote:
> On Sat, Jun 16, 2007 at 01:27:21PM -0600, Scott Long wrote..
> > Wilko Bulte wrote:
> > > wilko       2007-06-16 19:20:02 UTC
> > > 
> > >   FreeBSD src repository
> > > 
> > >   Modified files:
> > >     sys/dev/usb          ukbd.c 
> > >   Log:
> > >   Per request (to core) by the person refered to in the comment.
> > >   
> > >   Revision  Changes    Path
> > >   1.65      +0 -2      src/sys/dev/usb/ukbd.c
> > 
> > This commit message makes no sense.
> 
> I removed the 2 lines with the guys name/email address.
> 
Which wasn't clear from the commit message.  One needs to look up the
diff to find out *what* has happened while the commit message only
contains *why* it happened.  The commit message should include both.

"Remove comment per request (to core) from the person mentioned in it"

Cheers,
-erwin

-- 
Erwin Lansing                                     http://droso.org
Security is like an onion.          (o_ _o)
It's made up of several layers   \\\_\   /_///    erwin at FreeBSD.org
And it makes you cry.            <____) (____>    erwin at aauug.dk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20070616/19e2540b/attachment.pgp