cvs commit: src/sys/net80211 ieee80211_radiotap.h

M. Warner Losh imp at bsdimp.com
Mon Jun 11 20:52:07 UTC 2007


In message: <466DAD3E.7090106 at errno.com>
            Sam Leffler <sam at errno.com> writes:
: Warner Losh wrote:
: > imp         2007-06-11 19:34:53 UTC
: > 
: >   FreeBSD src repository
: > 
: >   Modified files:
: >     sys/net80211         ieee80211_radiotap.h 
: >   Log:
: >   Prefer __packed to __attribute__((__packed__)).
: >   
: >   OK'd by sam@ months ago...
: >   
: >   Revision  Changes    Path
: >   1.9       +1 -1      src/sys/net80211/ieee80211_radiotap.h
: > http://cvsweb.FreeBSD.org/src/sys/net80211/ieee80211_radiotap.h.diff?r1=1.8&r2=1.9
: > 
: > 
: This file is included in user code.  Is __packed commonly visible?

Yes.  Nothing that includes any kernel file could not have it defined
and visible, afaik.

: FWIW I've avoided tweaking this file as much as possible because of it's 
: shared heritage w/ netbsd.

I'll be happy to revert it.  I'm pretty sure the last time we talked
about it you said it was OK, however.  Maybe my memory is faulty, or
maybe things have changed.  I'll back it out if either of those are
the case if you think it is bad...

Warner


More information about the cvs-src mailing list