cvs commit: src/sys/netinet tcp_input.c tcp_usrreq.c

[mjacob at freebsd.org]

On Sun, 29 Jul 2007, Bjoern A. Zeeb wrote:

> On Sun, 29 Jul 2007, mjacob at freebsd.org wrote:
>
>> Here's what probably works. I'll do the test compiles.
>
> If I am not wrong it will not.
>
> The follwoing two files have comments at the beginning to explain the 
> changes.
> I don't like the extern char *tcpstates[] but it seems to be the best
> solution for now.

No, that's what's actually wrong. tcpstates has to be static to honor 
the intent of the original author. If you want to do something extern 
then the actual tcpstates should go into tcp_debug.c. However, this is 
slightly less flexible in that the way it is now each source file can 
include this array simply by defining TCPSTATES (independent of TCPDEBUG 
as an option).

This is all incredible microopt goop. The only reason I didn't just 
simply make this an always visible thing is that it really dates to all 
intents and purposes from the end of the PDP-11 era where the inclusion 
of this array or not was really worth worrying about.