cvs commit: src/sys/fs/devfs devfs_vnops.c src/sys/fs/fifofs fifo_vnops.c src/sys/kern uipc_usrreq.c vfs_vnops.c src/sys/vm vnode_pager.c

[Pawel Jakub Dawidek]

On Thu, Jul 26, 2007 at 02:18:58PM -0400, John Baldwin wrote:
> On Thursday 26 July 2007 12:58:10 pm Pawel Jakub Dawidek wrote:
> > pjd         2007-07-26 16:58:09 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/fs/devfs         devfs_vnops.c 
> >     sys/fs/fifofs        fifo_vnops.c 
> >     sys/kern             uipc_usrreq.c vfs_vnops.c 
> >     sys/vm               vnode_pager.c 
> >   Log:
> >   When we do open, we should lock the vnode exclusively. This fixes few 
> races:
> >   - fifo race, where two threads assign v_fifoinfo,
> >   - v_writecount modifications,
> >   - v_object modifications,
> >   - and probably more...
> 
> Is it possible this could fix some 'vrele: negative ref cnt' and 'vput: 
> negative ref cnt' panics I am seeing on 6.x?

I see similar panic on NFS root vnode, but this change won't fix it.
v_usecount is protected by vnode's internal lock, not vnode lock.

-- 
Pawel Jakub Dawidek                       http://www.wheel.pl
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20070726/15f81b31/attachment.pgp