cvs commit: src/sys/dev/re if_re.c src/sys/pci if_rlreg.h

Pyun YongHyeon yongari at
Fri Jul 13 04:46:34 UTC 2007

yongari     2007-07-13 04:46:34 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    sys/dev/re           if_re.c 
    sys/pci              if_rlreg.h 
  MFC if_re.c rev. 1.91, if_rlreg.h rev. 1.66 to RELENG_6.
    re(4) devices requires an external EEPROM. Depending on models it
    would be 93C46(1Kbit) or 93C56(2Kbit). One of differences between them
    is number of address lines required to access the EEPROM. For example,
    93C56 EEPROM needs 8 address lines to read/write data. If 93C56
    recevied premature end of required number of serial clock(CLK) to set
    OP code/address of EEPROM, the result would be unexpected behavior.
    Previously it tried to detect 93C46, which requires 6 address lines,
    and then assumed it would be 93C56 if read data was not expected
    value. However, this approach didn't work in some models/situations
    as 93C56 requries 8 address lines to access its data. In order to fix
    it, change EEPROM probing order such that 93C56 is detected reliably.
    While I'm here change hard-coded address line numbers with defined
    constant to enhance readability.
  PR:     112710
  Revision   Changes    Path  +2 -2      src/sys/dev/re/if_re.c  +2 -0      src/sys/pci/if_rlreg.h

More information about the cvs-src mailing list