cvs commit: src/sys/kern sysv_sem.c

John Baldwin jhb at freebsd.org
Tue Jul 3 18:32:10 UTC 2007


On Tuesday 03 July 2007 11:58:48 am Konstantin Belousov wrote:
> kib         2007-07-03 15:58:48 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/kern             sysv_sem.c 
>   Log:
>   Relock the sema_mtxp unconditionally after copyin() for SETALL case in
>   kern_semctl. Otherwise, later mtx_unlock() can operate on unlocked mutex.
>   
>   Submitted by:   rdivacky
>   MFC after:      3 days
>   Approved by:    re (kensmith)

Good catch.  Another thing you could fix is to make all the 'goto done2' 
inside the switch cases just use 'break' instead.

-- 
John Baldwin


More information about the cvs-src mailing list