cvs commit: src/sys/netgraph ng_ppp.c

David O'Brien obrien at
Thu Jan 18 19:27:52 UTC 2007

On Thu, Jan 18, 2007 at 01:55:21PM +0000, Gleb Smirnoff wrote:
> glebius     2007-01-18 13:55:21 UTC
>   FreeBSD src repository
>   Modified files:
>     sys/netgraph         ng_ppp.c 
>   Log:
>   Revise the ng_ppp(4) node, so that code flow is more clear. All non-link
>   hooks get their per hook rcvdata methods, and all functions are organized
>   corresponding to protocol stack model.

Hi glebius,
This seems to have broken the kernel build:
/usr/src/sys/modules/netgraph/ppp/../../../netgraph/ng_ppp.c: In function `ng_ppp_rcvdata':
/usr/src/sys/modules/netgraph/ppp/../../../netgraph/ng_ppp.c:1287: warning: comparison is always true due to limited range of data type
*** Error code 1

I commented out the KASSERT in order to get the kernel buildable again.
Would you be able to take a look at the logic in the KASSERT?  I'd rather
not guess what you'd like there and possibly get it wrong.
-- David  (obrien at

More information about the cvs-src mailing list