cvs commit: src/sys/kern kern_ntptime.c

M. Warner Losh imp at bsdimp.com
Fri Jan 12 15:59:11 UTC 2007


In message: <20070112140211.G555 at atlantis.atlantis.dp.ua>
            Dmitry Pryanishnikov <dmitry at atlantis.dp.ua> writes:
: 
: Hello!
: 
: On Fri, 12 Jan 2007, Warner Losh wrote:
: >    sys/kern             kern_ntptime.c
: >  Log:
: >  When ntp_gettime() was converted from a sysctl + wrapper to a system
: >  call, its semantics were unintentionally changed.  It went from
: >  returning the time state to returning 0 or -1.  Since 0 means time
: 
:    Shouldn't the manpage lib/libc/sys/ntp_gettime.2 also be updated? It claims
: now:
: 
: RETURN VALUES
:       The ntp_gettime() function returns the value 0 if successful; otherwise
:       the value -1 is returned and the global variable errno is set to indicate
:       the error.
: 
:       Possible states of the clock are:
:  	...
: 
: So it still refers to old behaviour (return either 0 or -1), which is 
: confusing enough.

Yes.  This needs to be fixed.

Warner


More information about the cvs-src mailing list