cvs commit: src/sbin/ifconfig af_atalk.c af_inet.c af_inet6.c af_ipx.c af_link.c ifconfig.c ifconfig.h

Sam Leffler sam at
Tue Feb 27 17:41:19 UTC 2007

Dag-Erling Smørgrav wrote:
> Sam Leffler <sam at> writes:
>> Dag-Erling Smørgrav wrote:
>>> This commit breaks interface cloning.  Apparently, the global variable
>>> "name" is not initialized before ifclonecreate() is called, so the
>>> SIOCIFCREATE2 ioctl() is called with an empty string instead of the
>>> interface name.
>> Hmm, worked for bridge for me.  Can you provide the specific example?
> Is "ifconfig bridge0 create" specific enough?
> Insert a printf() in the right spot and you'll see name is empty when
> ifclonecreate() is called.

I'd (apparently) tested with a wrong binary.  Unfortunately noone caught
it in the public review either.


More information about the cvs-src mailing list