cvs commit: src/sys/dev/iwi if_iwi.c if_iwivar.h

Max Laier max at love2party.net
Tue Feb 20 16:11:08 UTC 2007


On Tuesday 20 February 2007 16:45, Luigi Rizzo wrote:
> luigi       2007-02-20 15:45:59 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/dev/iwi          if_iwi.c if_iwivar.h
>   Log:
>   Address a few issues with the iwi driver, namely:
...
>   + add debugging code IWI_LOCK_ASSERT() to detect missing locks.
>     These only do a printf, and should go away once we figure out why
>     the driver sometimes freezes the system due to a (yet unidentified)
>     race condition.
>
>   + add a device_printf() in iwi_ioctl() in certain conditions
>     (see comment in the code).  This helps preventing the race
> condition mentioned above, and makes the system survive. This printf
> will also go away once fixing this bug is completed.
...
>   The bugs fixed by this commit (the freezing one especially) are
> serious enough to call for a quick MFC

... but since it is only a stopgap sollution, shouldn't we try to figure 
this out in HEAD and MFC the proper sollution once we found it?

>   MFC after: 3 days
>
>   Revision  Changes    Path
>   1.47      +127 -78   src/sys/dev/iwi/if_iwi.c
>   1.13      +20 -0     src/sys/dev/iwi/if_iwivar.h

-- 
/"\  Best regards,                      | mlaier at freebsd.org
\ /  Max Laier                          | ICQ #67774661
 X   http://pf4freebsd.love2party.net/  | mlaier at EFnet
/ \  ASCII Ribbon Campaign              | Against HTML Mail and News
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20070220/d87efa90/attachment.pgp


More information about the cvs-src mailing list