cvs commit: src/sys/dev/mii rlphy.c

Warner Losh imp at
Thu Feb 8 19:16:16 UTC 2007

imp         2007-02-08 19:16:15 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/mii          rlphy.c 
  Fix problem with RTL8201L PHY.  From submitter:
      Bugfix for the Realtek PHY driver... an RTL8201L standalone PHY
      needs different handling than the integrated ones in terms of
      speed detection.  There was a bogus test based on the parent
      device driver name string controlling which speed register to
      query.  That test began failing when the rl driver was split into
      separate rl and re drivers some time ago.  Apparently nobody ever
      noticed because the buggy code only executes if NWAY negotiation
      failed.  Since we happen to be testing with an ancient dumb hub
      rather than a modern switch, we found it.
      To fix it all, have the attach() routine notice whether we're
      dealing with an integrated PHY or an RTL8201L and store that info
      in a struct accessible to the status() routine that needs to know
      which register to query.
  I touched up the fixes because they were relative to RELENG_6 and to
  bring a few nits into line with style(9).
  MFC After: 2 weeks
  Submitted by: Ian Lepore
  Revision  Changes    Path
  1.29      +17 -2     src/sys/dev/mii/rlphy.c

More information about the cvs-src mailing list