cvs commit: src/sys/net if_tap.c

Eygene Ryabinkin rea-fbsd at codelabs.ru
Mon Feb 5 13:11:41 UTC 2007


> btw, we have a strange situation with handling off non-broadcast
> frames not destined to us in general.
> 
> In a case, when we have generic Ethernet in promisc, and received foreign
> packets (on a hub, or a buggy switch), they are forwarded to ether_demux()
> and to upper layers respectively. Isn't this incorrect?
> 
> Moreover, in case of promisc + net.inet.ip.forwarding=1 our box will resend
> all the received foreign packets :(
> 
> What do you think about checking that (ether_dhost == ours || BCAST || MCAST)
> before sending packet to ether_demux?

If you will do so, please, do not forget to check if we're doing
bridging, because your proposal will break it. If I understand the
things correctly ;))
-- 
Eygene


More information about the cvs-src mailing list