cvs commit: src/sys/net if_tap.c

Gleb Smirnoff glebius at
Mon Feb 5 12:54:18 UTC 2007

On Mon, Feb 05, 2007 at 03:52:44PM +0300, Eygene Ryabinkin wrote:
E> > btw, we have a strange situation with handling off non-broadcast
E> > frames not destined to us in general.
E> > 
E> > In a case, when we have generic Ethernet in promisc, and received foreign
E> > packets (on a hub, or a buggy switch), they are forwarded to ether_demux()
E> > and to upper layers respectively. Isn't this incorrect?
E> > 
E> > Moreover, in case of promisc + net.inet.ip.forwarding=1 our box will resend
E> > all the received foreign packets :(
E> > 
E> > What do you think about checking that (ether_dhost == ours || BCAST || MCAST)
E> > before sending packet to ether_demux?
E> If you will do so, please, do not forget to check if we're doing
E> bridging, because your proposal will break it. If I understand the
E> things correctly ;))

Don't worry. The bridge input is before ether_demux().

Totus tuus, Glebius.

More information about the cvs-src mailing list