cvs commit: src/bin/cp cp.c

Peter Jeremy peterjeremy at optushome.com.au
Mon Dec 24 22:45:56 PST 2007


On Tue, Dec 25, 2007 at 12:40:32AM +0000, Edwin Groothuis wrote:
>  When copying multiple files to a directory, make sure that a proper
>  warning is given when the directory doesn't exist.

	warnx("Target is not a directory");
	exit(1);
would be more simply expressed as
	errx(1, "Target is not a directory");

Maybe you should report the target name:
	errx(1, "%s is not a directory", to.p_path);

>  Submitted by:   Edwin Groothuis <edwin at mavetju.org>

Normally, you don't bother listing yourself as the author.

-- 
Peter Jeremy
Please excuse any delays as the result of my ISP's inability to implement
an MTA that is either RFC2821-compliant or matches their claimed behaviour.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20071225/5db4aeca/attachment.pgp


More information about the cvs-src mailing list