cvs commit: src/usr.sbin/sysinstall main.c

[Andrey Chernov]

On Mon, Apr 30, 2007 at 11:00:43AM -0700, Alfred Perlstein wrote:
> * Andrey A. Chernov <ache at FreeBSD.org> [070430 08:17] wrote:
> > ache        2007-04-30 15:16:19 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     usr.sbin/sysinstall  main.c 
> >   Log:
> >   Preparing for upcoming POSIXed putenv() rewrite:
> >   don't allow const as putenv() arg, dup it
> >   
> >   Revision  Changes    Path
> >   1.75      +1 -1      src/usr.sbin/sysinstall/main.c
> 
> Maybe this was mentioned on the lists, but couldn't there be some
> kind of define that old code could use like #define BSD_PUTENV?

Why? We must follow standards to stay in line with possible concurrents, 
and we already are several years later with that. Even in case some 
applications will be found incompatible, they forced to follow standards 
too to continue works in the modern environment.

> I'm concerned that all these changes could lead to security
> holes.

Please be specific. Which changes exactly you means? Changes to 
applications works with any putenv() kind, they are just portablility 
fixes, no holes there. Changes to the library aren't under the question 
too: you can just directly modify **environ variable from your own code 
bypassing any setenv and putenv - they are just convenient interface.

-- 
http://ache.pp.ru/