cvs commit: src/usr.sbin/sysinstall main.c

John Baldwin jhb at
Mon Apr 30 16:29:25 UTC 2007

On Monday 30 April 2007 11:16:19 am Andrey A. Chernov wrote:
> ache        2007-04-30 15:16:19 UTC
>   FreeBSD src repository
>   Modified files:
>     usr.sbin/sysinstall  main.c 
>   Log:
>   Preparing for upcoming POSIXed putenv() rewrite:
>   don't allow const as putenv() arg, dup it

Have you coordinated at all with the guy on current@ who has patches to make 
setenv(3) not leak memory as bad?  Also, given that we malloc a limited space 
for the string values, I don't see how you can make it so that one can always 
just overwrite the string pointed to by putenv(3)'s return value to change 
the value.  If we malloc a buffer for length N and the user wants to set the 
length to M > N, we pretty much have to malloc a new buffer that will end up 
at a different address, so places holding onto the previous value returned 
from putenv(3) will stop seeing updates.

John Baldwin

More information about the cvs-src mailing list