cvs commit: src/contrib/top top.X top.c top.h src/usr.bin/top machine.c

[Stanislav Sedov]

On Sat, 14 Apr 2007 12:35:59 +0200
Pav Lucistnik <pav at FreeBSD.org> mentioned:
>
> Also, is the width cut-off technical problem, or is it fixable?
> See http://people.freebsd.org/~pav/top.png for what I mean.
>

Well, they allocate a static buffer of 128 byte lenght, so the result
doesn't fit into it. Also, there's buffer overrun, since sprintf is
used, not snprintf.

Probably we should allocate the buffer dynamically depending on the
screen width, but that requires some interface redesign between
machine-dependent and independent parts. Already working on it.

Thanks for info!

--
Stanislav Sedov
ST4096-RIPE
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20070414/4e130957/attachment.pgp