cvs commit: src/include stdio.h src/lib/libc/sys lseek.2 pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h

[Andrey Chernov]

On Fri, Apr 06, 2007 at 12:35:19PM +0200, Pawel Jakub Dawidek wrote:
> > > These are just namespace pollution in stdio.h.  stdio (fseek()) doesn't
> > > support them, and the hack of declaring lseek() in stdio.h should not
> > > be extended to new interfaces.  If stdio ever supports them, then they
> > > would need to be declared under a visibility ifdef (not #ifdef self).
> > 
> > I agree. They must be implemented in fseek.c code first before adding them 
> > to stdio.h and ifdefed with proper *_VISIBLE tags in all places.
> > Perhaps new __CDDL_VISIBLE tag required for it.
> 
> This is not CDDL licensed. I'm planning to implement support for
> SEEK_DATA and SEEK_HOLE for UFS.

This is not matter of license at all but matter of standards conformance.

Feel free to invent any other __*_VISIBLE tag to exclude this addition 
from namespace for programs which may define their own SEEK_DATA etc 
which is allowed f.e. in POSIX namespace. Look like other __*_VISIBLE tags 
are implemented and what they does. Default is turn all on.

In any case adding them to stdio.h is premature action - I not see yet
corresponding fseek() code.

-- 
http://ache.pp.ru/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20070406/d63be474/attachment.pgp