cvs commit: src/sys/pci if_vr.c

Coleman Kane zombyfork at
Mon Apr 2 02:42:32 UTC 2007

On 4/1/07, Dag-Erling Smørgrav <des at> wrote:
> Colin Percival <cperciva at> writes:
> > Judging by what I see at,
> > it looks like everything has been reverted now, so hopefully Kris can go
> > ahead and redo his original commit later today without any of the
> changes
> > which slipped in by mistake.
> Great!  I have a megapatch lined up as well.  In the spirit of
> sustainable kernel development, atomic operations are being renamed to
> renewable operations.
> --
> Dag-Erling Smørgrav - des at
> _______________________________________________
> cvs-src at mailing list
> To unsubscribe, send any mail to "cvs-src-unsubscribe at"

I think that I may just have to start a thread to protest your renewable
operations patch. The naming conventions used in the new macros
unnecessarily stick out under review of the source code where they are
implemented, thus overshadowing and blocking out my abilities to inspect
less prominent features in the code where they are used.

I think that these aesthetic concerns in this situation override any
possible gains through reduction in operation waste, and the changes should
be reconsidered under these grounds. In addition, I (and others) fear that
these renewable operations will render the development of devel/liboil
obsolete, and its developers unemployed.

Coleman Kane

More information about the cvs-src mailing list