cvs commit: src/sys/conf NOTES src/sys/dev/isp isp_freebsd.c isp_freebsd.h isp_library.c isp_library.h isp_pci.c isp_sbus.c

Matt Jacob mjacob at
Mon Apr 2 01:04:21 UTC 2007

mjacob      2007-04-02 01:04:21 UTC

  FreeBSD src repository

  Modified files:
    sys/conf             NOTES 
    sys/dev/isp          isp_freebsd.c isp_freebsd.h isp_library.c 
                         isp_library.h isp_pci.c isp_sbus.c 
  Temporarily desupport simultaneous target and initiator mode.
  When the linux port changes were imported which split the
  target command list to be separate from the initiator command
  list and the handle format changed to encode a type in the handle
  the implications to the function isp_handle_index (which only
  the NetBSD/OpenBSD/FreeBSD ports use) were overlooked.
  The fault is twofold: first, the index into the DMA maps
  in  isp_pci is wrong because a target command handle with
  the type bit left in place caused a bad index (and panic)
  into dma map. Secondly, the assumption of the array
  of DMA maps in either PCS or SBUS attachment structures is
  that there is a linear mapping between handle index and
  DMA map index. This can no longer be true if there are
  overlapping index spaces for initiator mode and target
  mode commands.
  These changes bandaid around the problem by forcing us
  to not have simultaneous dual roles and doing the appropriate
  masking to make sure things are indexed correctly. A longer
  term fix is being devloped.
  Revision  Changes    Path
  1.1418    +6 -2      src/sys/conf/NOTES
  1.137     +9 -1      src/sys/dev/isp/isp_freebsd.c
  1.104     +7 -1      src/sys/dev/isp/isp_freebsd.h
  1.13      +7 -7      src/sys/dev/isp/isp_library.c
  1.8       +2 -0      src/sys/dev/isp/isp_library.h
  1.142     +8 -6      src/sys/dev/isp/isp_pci.c
  1.32      +5 -3      src/sys/dev/isp/isp_sbus.c

More information about the cvs-src mailing list