cvs commit: src/sys/pci if_vr.c

Colin Percival cperciva at
Sun Apr 1 10:00:14 UTC 2007

Kostik Belousov wrote:
> On Sun, Apr 01, 2007 at 07:03:43AM +0000, Kris Kennaway wrote:
>>   Modified files:
>>     sys/pci              if_vr.c 
>>   Log:
>>   Fix a search-and-replace bug that slipped through my diff review of the
>>   Giant pushdown.
> Did you ever test _your_ changes, at least with half of the care you
> put into finding bugs in commits of others ?
> You fixed the if_vr.c, but not the flag definition in if_vrreg.h, thus
> breaking the build !

I pointed this out to Kris a couple of hours ago, but by that point the
CVS meisters were already partway through undoing Kris' commit due to
an unrelated issue (accidentally taking files off the vendor branch), so
we agreed that it was easiest just to wait for the entire commit to be
undone rather than fixing this with another commit.

Judging by what I see at,
it looks like everything has been reverted now, so hopefully Kris can go
ahead and redo his original commit later today without any of the changes
which slipped in by mistake.

Colin Percival

More information about the cvs-src mailing list