cvs commit: src/sys/dev/bge if_bge.c

[Jung-uk Kim]

On Tuesday 19 September 2006 01:52 pm, John Baldwin wrote:
> On Monday 18 September 2006 19:01, Jung-uk Kim wrote:
> > On Monday 18 September 2006 06:33 pm, Christian S.J. Peron wrote:
> > > Jung-uk Kim wrote:
> > > > jkim        2006-09-18 22:18:22 UTC
> > > >
> > > >   FreeBSD src repository
> > > >
> > > >   Modified files:
> > > >     sys/dev/bge          if_bge.c
> > > >   Log:
> > > >   Do not strip VLAN tag in promiscuous mode.
> > > >
> > > >   Revision  Changes    Path
> > > >   1.148     +28 -15    src/sys/dev/bge/if_bge.c
> > >
> > > I don't think this is right. An interface does not have to be
> > > in promiscuous mode in order to have BPF peers attached to it.
> > > If this is being done to ensure that vlan info is preserved for
> > > things like tcpdump, the correct fix is to use
> > > bpf_peers_present() instead.
> >
> > Yes, I know that.  This is just a stopgap until we have 'correct'
> > fix. BTW, I am just following bad example, i.e., em(4). ;-)
>
> Which I'm about to kill hopefully.  Please let's fix this the right
> way and not hack it any further.

Sure, no problem.  But I don't think we can DTRT on -STABLE without 
breaking API.  Can we?

Jung-uk Kim