cvs commit: src/sys/dev/bce if_bce.c src/sys/dev/bge if_bge.c src/sys/dev/em if_em.c src/sys/dev/ixgb if_ixgb.c src/sys/dev/nfe if_nfe.c src/sys/dev/nge if_nge.c src/sys/dev/re if_re.c src/sys/dev/stge if_stge.c src/sys/dev/ti if_ti.c src/sys/dev/txp ...

[John Baldwin]

On Sunday 17 September 2006 09:33, Andre Oppermann wrote:
> andre       2006-09-17 13:33:30 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/bce          if_bce.c 
>     sys/dev/bge          if_bge.c 
>     sys/dev/em           if_em.c 
>     sys/dev/ixgb         if_ixgb.c 
>     sys/dev/nfe          if_nfe.c 
>     sys/dev/nge          if_nge.c 
>     sys/dev/re           if_re.c 
>     sys/dev/stge         if_stge.c 
>     sys/dev/ti           if_ti.c 
>     sys/dev/txp          if_txp.c 
>     sys/dev/vge          if_vge.c 
>     sys/net              if_vlan.c if_vlan_var.h 
>     sys/net80211         ieee80211_input.c ieee80211_output.c 
>     sys/netgraph         ng_vlan.c 
>     sys/sys              mbuf.h 
>   Log:
>   Move ethernet VLAN tags from mtags to its own mbuf packet header field
>   m_pkthdr.ether_vlan.  The presence of the M_VLANTAG flag on the mbuf
>   signifies the presence and validity of its content.

Did you ever get a chance to benchmark this?  I know in principle it should be 
faster, but as I had mentioned to you earlier, sometimes things that seem 
like they should be faster end up being slower, so it's generally helpful to 
verify one's assumptions with actual benchmarks or testing, etc.  Also, it 
would have been helpful to have Robert's review on this as he has been 
talking about moving the vlan stuff into the ether input/output routines for 
quite a while now.

-- 
John Baldwin