cvs commit: src/sys/nfsserver nfs.h nfs_serv.c nfs_srvsubs.c

Robert Watson rwatson at FreeBSD.org
Fri Nov 24 03:53:18 PST 2006


rwatson     2006-11-24 11:53:17 UTC

  FreeBSD src repository

  Modified files:
    sys/nfsserver        nfs.h nfs_serv.c nfs_srvsubs.c 
  Log:
  Push Giant a bit further off the NFS server in a number of straight
  forward cases by converting from unconditional acquisition of Giant
  around vnode operations to conditional acquisition:
  
  - Remove nfsrv_access_withgiant(), and cause nfsrv_access() to now
    assert that Giant will be held if it is required for the vnode.
  
  - Add nfsrv_fhtovp_locked(), which will drop the NFS server lock if
    required, and modify nfsrv_fhtovp() to conditionally acquire
    Giant if required.
  
  - In the VOP's not dealing with more than one vnode at a time (i.e.,
    not involving a lookup), conditionally acquire Giant.
  
  This removes Giant use for MPSAFE file systems for a number of quite
  important RPCs, including getattr, read, write.  It leaves
  unconditional Giant acquisitions in vnode operations that interact
  with the name space or more than one vnode at a time as these
  require further work.
  
  Tested by:      kris
  Reviewed by:    kib
  
  Revision  Changes    Path
  1.81      +3 -0      src/sys/nfsserver/nfs.h
  1.168     +263 -213  src/sys/nfsserver/nfs_serv.c
  1.144     +31 -11    src/sys/nfsserver/nfs_srvsubs.c


More information about the cvs-src mailing list