cvs commit: src/sys/fs/nullfs null_vfsops.c

Scott Long scottl at samsco.org
Sun May 28 13:21:37 PDT 2006


Craig Rodrigues wrote:

> rodrigc     2006-05-28 20:09:18 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/fs/nullfs        null_vfsops.c 
>   Log:
>   Modify MNT_UPDATE behavior for nullfs so that it does not
>   return EOPNOTSUPP if an "export" parameter was passed in.
>   This should allow nullfs mounts to be NFS exported.
>   
>   PR:             kern/87906
>   MFC after:      1 week
>   
>   Revision  Changes    Path
>   1.78      +7 -2      src/sys/fs/nullfs/null_vfsops.c

No, it won't.  The null_checkexp routine is wrong.  It should be
removed so that the default stdcheckexp routine will be called.
Why?  Because what null_checkexp is doing right now is passing
the call down to the lower filesystem.  If that filesystem isn't
also exported, then the call will fail.  When you export nullfs,
you are exporting the nullfs mountpoint, not the lower mountpoint.
Thus, there is no need to play the mountpoint pivot games with this
call.

Scott



More information about the cvs-src mailing list