cvs commit: src/sys/netipsec xform.h xform_ipip.c
Bjoern A. Zeeb
bz at FreeBSD.org
Thu Mar 30 19:55:16 UTC 2006
On Thu, 30 Mar 2006, Max Laier wrote:
> On Thursday 30 March 2006 21:17, Bjoern A. Zeeb wrote:
>> On Thu, 30 Mar 2006, Bjoern A. Zeeb wrote:
>>> bz 2006-03-30 18:57:04 UTC
>>> FreeBSD src repository
>>> Modified files:
>>> sys/netipsec xform.h xform_ipip.c
>>> Fix more stack corruptions on amd64.
>>> Vararg functions have a different calling convention than regular
>>> functions on amd64. Casting a varag function to a regular one to
>>> match the function pointer declaration will hide the varargs from
>>> the caller and we will end up with an incorrectly setup stack.
>> I will try to go over sys/net*/** or even sys/** somewhen the next
>> days and see if I can find more of them.
>> If anybody knows an easy way to find all casted function pointers
>> that are using varargs let me know ;-)
> Shouldn't we be able to teach Coverity? It certainly has the information
next question: why does the compiler not complain?
Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT
More information about the cvs-src