cvs commit: src/sys/dev/le am7990.c am79900.c if_le_ledma.c if_le_pci.c lance.c lancereg.h lancevar.h

Marius Strobl marius at
Sun Jun 18 15:43:19 UTC 2006

marius      2006-06-18 15:43:18 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    sys/dev/le           am7990.c am79900.c if_le_ledma.c 
                         if_le_pci.c lance.c lancereg.h lancevar.h 
  MFC: am7990.c 1.3, am79900.c 1.3, if_le_ledma.c 1.2, if_le_pci.c 1.2 - 1.4,
       lance.c 1.2, lancereg.h 1.2, lancevar.h 1.2
  - Rearrange the code related to RX interrupt handling so that ownership of
    RX descriptors is immediately returned to the NIC after we have copied
    the data of the hardware, allowing the NIC to already reuse the descriptor
    while we are processing the data in ifp->if_input(). This results in a
    small but measurable increase in RX throughput.
    As a side-effect, this moves the workaround for the LANCE revision C bug
    to am7900.c (still off by default as I doubt we will actually encounter
    such an old chip in a machine running FreeBSD) and the workaround for the
    bug in the VMware PCnet-PCI emulation to am79000.c, which is now also
    only compiled on i386 (resulting in a small increase in RX throughput on
    the other platforms).
  - Change the RX interrupt handlers so that the descriptor error bits are
    only check once in case there was no error instead of twice (inspired
    by the NetBSD pcn(4), which additionally predicts the error branch as
  - Fix the debugging output of the RX and TX interrupt handlers; while
    looping through the descriptors print info about the currently processed
    one instead of always the previously last used one; remove pointless
    printing of info about the RX descriptor bits after their values were
  - Create the DMA tags used to allocate the memory for the init block,
    descriptors and packet buffers with the alignment the respective NIC
    actually requires rather than using PAGE_SIZE unconditionally. This might
    as well fix the alignment of the memory as it seems we do not inherit
    the alignment constraint from the parent DMA tag.
  - For the PCI variants double the number of RX descriptors and buffers
    from 8 to 16 as this minimizes the number of RX overflows im seeing with
    one NIC-mainboard combination. Nevertheless move reporting of overflows
    under debugging as they seem unavoidable with some crappy hardware.
  - Add a comment regarding usage of ILACC vs. PCnet-PCI mode.
  - Fix the driver name part in the MODULE_DEPEND of the PCI front-end for
  - Use different device descriptions for PCnet-Home and PCnet-PCI.
  - Fix some 0/NULL confusion in lance_get().
  - Use bus_addr_t for sc_addr and bus_size_t for sc_memsize as these are
    more appropriate than u_long for these.
  - Remove the unused LE_DRIVER_NAME macro.
  - Add a comment describing why we are taking the LE_HTOLE* etc approach
    instead of using byteorder(9) functions directly.
  - Improve some comments and fix some wording.
  Revision  Changes    Path   +67 -39    src/sys/dev/le/am7990.c   +66 -42    src/sys/dev/le/am79900.c   +5 -3      src/sys/dev/le/if_le_ledma.c   +28 -8     src/sys/dev/le/if_le_pci.c   +14 -118   src/sys/dev/le/lance.c   +1 -1      src/sys/dev/le/lancereg.h   +51 -6     src/sys/dev/le/lancevar.h

More information about the cvs-src mailing list