cvs commit: src/sys/netinet tcp_input.c tcp_syncache.c tcp_var.h

Robert Watson rwatson at
Sun Jun 18 00:37:56 UTC 2006

On Sat, 17 Jun 2006, Andre Oppermann wrote:

>  Revision  Changes    Path
>  1.299     +9 -6      src/sys/netinet/tcp_input.c
>  1.87      +286 -255  src/sys/netinet/tcp_syncache.c
>  1.130     +9 -6      src/sys/netinet/tcp_var.h

This change appears to have broken world on all architectures by exposing the 
mutex data structure to usr.bin/netstat/inet.c via tcp_var.h.  I'm not quite 
sure what the "right" solution is, but if the syncache structures aren't 
actually used anywhere in user space, sticking them under #ifdef _KERNEL is 
probably a good start.

The UDP and TCP monitoring code more generally suffer from the problem of 
exposing their internal data structures for user space monitoring purposes.

Robert N M Watson
Computer Laboratory
University of Cambridge

More information about the cvs-src mailing list