cvs commit: src/sys/cam/scsi scsi_da.c src/sys/dev/usb umass.c usbdevs

[Nate Lawson]

Florent Thoumie wrote:
> flz         2006-01-30 20:27:44 UTC
> 
>   FreeBSD src repository (ports committer)
> 
>   Modified files:
>     sys/cam/scsi         scsi_da.c 
>     sys/dev/usb          umass.c usbdevs 
>   Log:
>   - Add a scsi_da.c and a umass.c quirk for Genesys 6-in-1 Card Reader.
>   
> --- src/sys/cam/scsi/scsi_da.c:1.185	Thu Jan 26 00:35:53 2006
> +++ src/sys/cam/scsi/scsi_da.c	Mon Jan 30 20:27:44 2006
> @@ -427,6 +427,14 @@
>  		{T_DIRECT, SIP_MEDIA_REMOVABLE, "*" , "USB DISK*",
>  		"*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
>  	},
> +	{
> +		/*
> +		 * Genesys 6-in-1 Card Reader
> +		 * No PR, reported by anders
> +		 */
> +		{T_DIRECT, SIP_MEDIA_REMOVABLE, "Generic*", "STORAGE DEVICE*",
> +		"*"}, /*quirks*/ DA_Q_NO_SYNC_CACHE
> +	},
>  };

I think it's bad to deviate from the policy we've established for 
handling quirks.  The reason why we need a PR is to track the following 
info:

# Output of "camcontrol inquiry yourdevice"
# Manufacturer name, model number, etc.
# Transport type (FC, SCSI, USB, Firewire)
# Output from dmesg for failed attach attempts
# Output from dmesg for successful attach attempts (after quirk added)
# Output of "usbdevs -v" with device attached
# Valid email address

An email address or posting is not enough since the user may discard the 
device later and it's tough to tell from the quirk itself exactly what 
device was causing the problem.  Case in point:  the quirk "Generic 
STORAGE DEVICE" you've added could match any number of devices.  Was 
this only a particular Genesys product or do all their products have 
this issue?  Without a way to track this info, it becomes impossible to 
decide.  PRs are the best current way to track things.

http://root.org/~nate/freebsd/scsi/quirks.html

Please stick to the policy of collecting the necessary information to 
help future maintainers.

-- 
Nate