cvs commit: src/lib/libc/rpc auth_des.c auth_none.c auth_unix.c
clnt_dg.c clnt_raw.c clnt_simple.c clnt_vc.c getpublickey.c
mt_misc.c mt_misc.h rpc_com.h rpc_generic.c rpc_soc.c rpcb_cl
deischen at freebsd.org
Tue Feb 28 08:07:46 PST 2006
On Tue, 28 Feb 2006, Xin LI wrote:
> On Mon, Feb 27, 2006 at 10:10:59PM +0000, Daniel Eischen wrote:
> > deischen 2006-02-27 22:10:59 UTC
> > FreeBSD src repository
> > Modified files:
> > lib/libc/rpc auth_des.c auth_none.c auth_unix.c
> > clnt_dg.c clnt_raw.c clnt_simple.c
> > clnt_vc.c getpublickey.c key_call.c
> > mt_misc.c rpc_com.h rpc_generic.c
> > rpc_soc.c rpcb_clnt.c svc.c svc_auth.c
> > svc_dg.c svc_generic.c svc_raw.c
> > svc_run.c svc_simple.c svc_vc.c
> > Added files:
> > lib/libc/rpc mt_misc.h
> I think we used to have a compiler bug which has hidden the
> API inconsistency where yp related functions having weak
> constant constraints, while the other part in libc do.
> Seems that getpublickey.c change has triggered the compiler
> to (correctly) generate warnings about the const/variable
> inconsistency, and thus broken the world... Perhaps we
> should add const constraint for certain yp related stuff?
I just committed a fix for this one particular problem. I
never got the error with my previous builds because I had
CFLAGS=-O -pipe in my /etc/make.conf.
I didn't test this with a buildworld, but I did make sure
that librpcsvc built, and that is the only consumer of
getpublicandprivatekey() that I found in our src tree.
More information about the cvs-src