cvs commit: src/sys/dev/fdc fdc.c

John Baldwin jhb at
Thu Feb 23 11:11:16 PST 2006

jhb         2006-02-23 19:11:16 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/fdc          fdc.c 
  - Use callout_init_mtx() to initialize toffhandle callout using the fdc's
  - Don't use callout_drain() to stop the toffhandle callout while holding the
    fdc mutex (this could deadlock) in functions called from softclock
    (callouts aren't allowed to do voluntary sleeps).  Instead, use
    callout_stop().  Note that since we hold the associated mutex and are now
    using callout_init_mtx(), callout_stop() is just as effective as
    callout_drain().  (Though callout_drain() is still needed in detach to
    make sure softclock isn't contesting on our mutex before we destroy the
  - Remove unused callout 'tohandle' from softc.
  MFC after:      1 week
  Revision  Changes    Path
  1.309     +5 -9      src/sys/dev/fdc/fdc.c

More information about the cvs-src mailing list