cvs commit: src/sys/netncp ncp_conn.c

Robert Watson rwatson at
Tue Feb 14 13:55:16 PST 2006

rwatson     2006-02-14 21:55:15 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    sys/netncp           ncp_conn.c 
  Merge ncp_conn.c:1.28 from HEAD to RELENG_6:
    In ncp_sysctl_connstat(), the SLIST_FOREACH() logic to check 'error'
    resulted in deadcode, as 'error' could never be 0.  What this logic
    was originally meant to handle is not clear -- it's been this way
    (broken) since at least RELENG_4.
    Found with:     Coverity Prevent(tm)
  Approved by:    re (scottl)
  Revision  Changes    Path  +1 -7      src/sys/netncp/ncp_conn.c

More information about the cvs-src mailing list