cvs commit: src/sys/kern tty.c

Martin Blapp mb at
Tue Dec 19 19:06:30 PST 2006


> Since proctree_lock is a sx lock which uses 2 condition variables,
> they alredy drop Giant (DROP_GIANT()) before sleeping. Are you secure
> it is the right thing to do here?

Sorry, the commit message was not 100% clear. It should have been:

Retest a variable after sx_slock has been called. Giant might have been 
temporarily dropped while waiting for proctree_lock, allowing for an
intervening tty_close() that cleared tp->t_session.


More information about the cvs-src mailing list