cvs commit: src/sys/net if_ethersubr.c

M. Warner Losh imp at bsdimp.com
Tue Dec 12 21:24:08 PST 2006


In message: <20061212203002.A51749 at xorpc.icir.org>
            Luigi Rizzo <rizzo at icir.org> writes:
: On Tue, Dec 12, 2006 at 09:13:23PM -0700, M. Warner Losh wrote:
: > In message: <20061212.140133.1649770385.imp at bsdimp.com>
: ...
: > : while established practice in NetBSD, met with considerable
: > : controversy when I tried to expand it in FreeBSD land.  However,
: > : putting things in param.h met with no resistance whatsoever and was
: > : actively suggested.  Maybe we should move this straggler from _types.h
: > : to param.h and start using it more often.
: > : 
: > : Warner
: > : 
: > 
: > Here's what I came up with this afternoon between fires at work.
: > 
: > Comments?
: 
: makes sense - there are probably more places where it should
: be used (judging by the output of "grep -r __sparc64__ sys/")

Yes.  I was going to do a complete audit, but wanted to get the
basic concepts signed off on first.

: just to make sure - are we guaranteed that param.h is included
: by every kernel file, or there is the risk that someone forgets
: it thus missing the #define __NO_STRICT_ALIGNMENT ?

I believe that we are...  The result of the discussion last time was
that's a pretty safe bet.

Warner


More information about the cvs-src mailing list