cvs commit: src/contrib/ipfilter HISTORY Makefile bpf_filter.c ip_fil.c ipf.h ipmon.h ipt.h kmem.h mlfk_rule.c opts.h radix.c radix_ipf.h snoop.h src/contrib/ipfilter/BSD Makefile Makefile.ipsend kupgrade src/contrib/ipfilter/iplang iplang_l.l ...

[Steve Kargl]

On Sat, Aug 26, 2006 at 12:08:54PM +1000, Peter Jeremy wrote:
> On Thu, 2006-Aug-24 18:44:02 -0400, Alexander Kabaev wrote:
> >personally. The mistake you made just shows how important it is to do a
> >buildworld _from freshly checked out sources_ after every major vendor
> >import.
> 
> I'm not sure how doing this would have prevented the breakage.  It
> might have allowed Guido to notice the breakage more quickly.

It would have caught the first problem, which I reported here
http://lists.freebsd.org/pipermail/freebsd-current/2006-August/065175.html.
This problem was fixed by kan as noted here
http://lists.freebsd.org/pipermail/cvs-src/2006-August/067536.html

Notice I reported the problem of Aug 16th.  Kan's patch was committed
on Aug 17th. 

> Guido made a mistake, has apologised and has corrected the problem in
> less than 6 hours.

He only corrected the second problem caused by his commit.

>  Doing a fresh checkout and a "make universe"
> (since "make buildworld" is not always sufficient to catch breakage)
> may not have been that much faster.

Huh?  If Guido had done a "make buildworld" or "make universe"
before he committed the source, then the problem would never have
existed.

-- 
Steve