PKGDIR ambiguous (was: cvs commit: src/usr.sbin/pkg_install/info info.h main.c perform.c pkg_info.1 src/usr.sbin/pkg_install/add add.h main.c perform.c pkg_add.1 src/usr.sbin/pkg_install/lib lib.h url.c)

[Kris Kennaway]

On Mon, Aug 21, 2006 at 12:27:20PM +0100, Florent Thoumie wrote:
> On Mon, 2006-08-21 at 07:07 -0400, Kris Kennaway wrote:
> > On Mon, Aug 21, 2006 at 08:09:45AM +0200, Raphael H. Becker wrote:
> > > 
> > > Hi Florent,
> > > 
> > > PKGDIR is ambiguous in the context of ports and packages.
> > > 
> > > I set PKGDIR=/some/where/my/pkg in my /etc/profile which causes the
> > > ports to fail badly creating any packages:
> > > 
> > > It is used in ports/Mk/bsd.port.mk:
> > > # PKGDIR                - A directory containing any package creation
> > > # files.
> > > #                                 Default: ${MASTERDIR}
> > > [...]
> > > PKGDIR?=                ${MASTERDIR}
> > > 
> > > Havin set PKGDIR statically is a very bad idea here.
> > 
> > Yes, PKGDIR is incorrect in this usage.  The documented place where
> > packages are stored is:
> > 
> > # PACKAGES              - A top level directory where all packages go (rather than
> > #                                 going locally to each port).
> > #                                 Default: ${PORTSDIR}/packages
> > #
> 
> PACKAGES is a better choice than PKGDIR, but I'd like to avoid confusion
> between "cached" packages (as in, copies of downloaded packages), and
> "home-brewed" packages. 

Not sure there is a need to; they're both just packages.

> That's why I was proposing PKG_CACHEDIR.
> 
> Moreover, I think there's no easy way to find the category of a package
> before it is downloaded.

You don't need to, you can download it to All/, and then postprocess.

Kris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/cvs-src/attachments/20060821/993eb05e/attachment.pgp