cvs commit: src/sbin/ifconfig ifclone.c ifconfig.c ifconfig.h ifvlan.c

[Yar Tikhiy]

On Sun, Jul 09, 2006 at 06:10:24AM +0000, Sam Leffler wrote:
> sam         2006-07-09 06:10:23 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sbin/ifconfig        ifclone.c ifconfig.c ifconfig.h ifvlan.c 
>   Log:
>   o replace special handling of clone operations by a clone callback
>     mechanism
>   o change vlan cloning to use callback and pass all vlan parameters
>     on create using the new SIOCREATE2 ioctl
>   o update vlan set logic to match existing practice
>   
>   Revision  Changes    Path
>   1.2       +35 -21    src/sbin/ifconfig/ifclone.c
>   1.120     +12 -23    src/sbin/ifconfig/ifconfig.c
>   1.18      +2 -2      src/sbin/ifconfig/ifconfig.h
>   1.12      +78 -54    src/sbin/ifconfig/ifvlan.c

Excuse me for noticing this late, but this change broke command
lines that had used to work, e.g:

# ifconfig vlan77 create vlan 77 vlandev xl0 mtu 1006 up
ifconfig: ioctl (set mtu): Device not configured
ifconfig: ioctl (SIOCGIFFLAGS): no such interface

My experience summarized in ifvlan.c rev. 1.11 showed that using
callbacks in ifconfig could be tricky because the order of processing
command-line parameters was important in some common cases.

-- 
Yar