cvs commit: src/sys/dev/em if_em.c if_em.h

Yar Tikhiy yar at comp.chem.msu.su
Tue Aug 8 10:01:00 UTC 2006


On Mon, Aug 07, 2006 at 03:45:56PM +0400, Gleb Smirnoff wrote:
> 
> P> Is there a report on what coverty found with if_em_hw.c?
> 
> Coverity complains that the return value of em_read_phy_reg() is
> somtimes checked and sometimes is not. Can you please tell, whether
> this is important report or can it be ignored?

FWIW, a return value can be cast to (void) to tell explicitly that
it doesn't matter.  While ignoring a return value from a well-known
function, such as close(), looks mostly OK to code readers (the
author knows what he's doing, they think,) it may not be the case
for a local function of limited application.

-- 
Yar


More information about the cvs-src mailing list